New: [rhinstaller/anaconda/pulls/19] Backport grub_raid_test.py from master

atodorov installerbot-noreply at redhat.com
Fri Feb 27 11:27:29 UTC 2015


A few notes here:

As is this test fails in grub_mbr_raid1_test(). See the lines:
```
 expected_targets = set([(self.sda, self.boot_md), (self.sdb, self.boot_md)])
# expected_targets = set([(self.sda, self.sda2), (self.sdb, self.sdb2)])
```

If the second one is used instead of the first one then the result is PASS. This is due to different support for GRUB stage2 between master and rhel7-branch. 

On RHEL7:
```
            for stage2dev in self.stage2_device.parents:
                # if target disk contains any of /boot array's member
                # partitions, set up stage1 on each member's disk
                # and stage2 on each member partition
                stage1dev = stage2dev.disk
                targets.append((stage1dev, stage2dev))
```

While on master:
```
       for stage2dev in stage2_parents:
                # if target disk contains any of /boot array's member
                # partitions, set up stage1 on each member's disk
                stage1dev = stage2dev.disk
                targets.append((stage1dev, self.stage2_device))
```

Notice the self.stage2_device vs. stage2dev. The first one is the md1 partition while the second one is either sda2 or sdb2 - the mdraid member partitions.  I don't know which one is the expected behavior for RHEL 7. 




-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/19


More information about the anaconda-patches mailing list