[anaconda:master 0/2] Make some parsing simpler and more consistant

Martin Kolman mkolman at redhat.com
Tue Feb 17 16:38:28 UTC 2015


On Fri, 2015-02-13 at 16:44 -0500, mulhern wrote:
> add_rpms parsing required a bit of post-processing, which code contained a few
> incorrect assumptions.  Using Action subclass simplifies the parsing a lot
> and puts the simplification in the parser, where it belongs.
> 
> ignore flag, added very recently, works exactly the same as add_rpms flag, so
> it makes sense to use same simple infrastructure for parsing.
> 
> mulhern (2):
>   Use a simple ExtendAction for add_rpms option.
>   Use ExtendAction for --ignore flag
> 
>  scripts/makeupdates | 46 +++++++++++++---------------------------------
>  1 file changed, 13 insertions(+), 33 deletions(-)
> 
Also looks good to me, ACK!



More information about the anaconda-patches mailing list