[anaconda][rhel7-branch][PATCH] Run nm-connection-editor with the --keep-above flag (#1231856)

Martin Kolman mkolman at redhat.com
Mon Aug 31 14:10:27 UTC 2015


On Mon, 2015-08-31 at 09:38 -0400, David Shea wrote:
> On 08/31/2015 09:18 AM, Martin Kolman wrote:
> > It was previously possible to hide the connection editor
> > window under the Anaconda one by clicking outside of it,
> > effectively loosing all unsaved data as there is no way to bring
> > the connection editor window back to foreground once it gets 
> > hidden.
> > 
> > So run the nm-connection-editor binary with the --keep-above flag,
> > which makes sure its window is always above the Anaconda one.
> > 
> > Resolves rhbz#1231856
> > 
> > Signed-off-by: Martin Kolman <mkolman at redhat.com>
> > ---
> >   pyanaconda/ui/gui/spokes/network.py | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/pyanaconda/ui/gui/spokes/network.py 
> > b/pyanaconda/ui/gui/spokes/network.py
> > index a45b095..54192a8 100644
> > --- a/pyanaconda/ui/gui/spokes/network.py
> > +++ b/pyanaconda/ui/gui/spokes/network.py
> > @@ -571,7 +571,7 @@ class NetworkControlBox(GObject.GObject):
> >           log.info("network: configuring connection %s device %s 
> > ssid %s",
> >                    uuid, devname, self.selected_ssid)
> >           self.kill_nmce(msg="Configure button clicked")
> > -        proc = startProgram(["nm-connection-editor", "--edit", 
> > "%s" % uuid], reset_lang=False)
> > +        proc = startProgram(["nm-connection-editor", "--keep
> > -above", "--edit", "%s" % uuid], reset_lang=False)
> >           self._running_nmce = proc
> >   
> >           GLib.child_watch_add(proc.pid, self.on_nmce_exited, 
> > activate)
> > @@ -661,7 +661,7 @@ class NetworkControlBox(GObject.GObject):
> >       def add_device(self, ty):
> >           log.info("network: adding device of type %s", ty)
> >           self.kill_nmce(msg="Add device button clicked")
> > -        proc = startProgram(["nm-connection-editor", "--create", "
> > --type=%s" % ty], reset_lang=False)
> > +        proc = startProgram(["nm-connection-editor", "--keep
> > -above", "--create", "--type=%s" % ty], reset_lang=False)
> >           self._running_nmce = proc
> >   
> >           GLib.child_watch_add(proc.pid, self.on_nmce_exited)
> 
> Ack. This can go on master, too.
Yep - network-manager-applet-1.0.6 seem to finally support the flag on
Fedora.
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list