[rhinstaller/blivet/pulls/215 master] Do not reserve extra space for metadata in a VG with RAID PVs

vpodzime installerbot-noreply at redhat.com
Thu Aug 27 08:47:42 UTC 2015


One thing I forgot to mention is that in the meantime (between this magic was introduced and now) we have added one nice thing to our code creating LVs -- every time an LV is about to be created, the free space in a VG is checked and the size of the LV is reduces in case there's less space in the VG than what is the calculated LV's size with a warning being logged. So even in cases where this prevented some issues, people should end up with better utilization of their storage, because an LV we would e.g. try to grow too big would be reduced and successfully created.

But generally, the lines this PR removes are clearly wrong. They just don't make sense and in cases where people use e.g. 32 MiB extent size (which was the default for kickstart installations few months ago, btw), those lines result in GiBs (5 * 5disks * 5LVs = 125 * 32 MiB) of unused space. Plus I'm not proposing this for the rhel7-branch so I don't think it could cause any serious issues.

Last but not least, I'm working on kickstart tests for LVM on RAID right now.
-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/215


More information about the anaconda-patches mailing list