[PATCH rhel7-branch] Process excludedGroupList after packages and groups.

Vratislav Podzimek vpodzime at redhat.com
Thu Aug 27 08:23:40 UTC 2015


On Wed, 2015-08-26 at 11:14 -0400, Chris Lumens wrote:
> The order we had things in was causing the excluded group to get
> removed, and then packages to get installed afterwards.  This is clearly
> the wrong order and had the effect of the conflicts groups not working
> like they are supposed to.
> 
> Resolves: rhbz#1249036
> ---
>  pyanaconda/packaging/yumpayload.py | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/pyanaconda/packaging/yumpayload.py 
> b/pyanaconda/packaging/yumpayload.py
> index a21ad16..ff7ef14 100644
> --- a/pyanaconda/packaging/yumpayload.py
> +++ b/pyanaconda/packaging/yumpayload.py
> @@ -1308,12 +1308,6 @@ reposdir=%s
>              except NoSuchGroup as e:
>                  self._handleMissing(e)
>  
> -        for group in self.data.packages.excludedGroupList:
> -            try:
> -                self._deselectYumGroup(group.name)
> -            except NoSuchGroup as e:
> -                self._handleMissing(e)
> -
>          for package in self.data.packages.packageList:
>              try:
>                  self._selectYumPackage(package)
> @@ -1323,6 +1317,12 @@ reposdir=%s
>          for package in self.data.packages.excludedList:
>              self._deselectYumPackage(package)
>  
> +        for group in self.data.packages.excludedGroupList:
> +            try:
> +                self._deselectYumGroup(group.name)
> +            except NoSuchGroup as e:
> +                self._handleMissing(e)
> +
>          self._select_kernel_package()
>          self.selectRequiredPackages()
Wouldn't this result in packages requested to be installed not installed if they
are in an excluded group? I mean something like:

%packages
git
- at Development tools
%end

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list