Updated: [rhinstaller/blivet/pulls/207 master] Better calculate required space for LVM cache

vpodzime installerbot-noreply at redhat.com
Wed Aug 19 13:51:04 UTC 2015


This pull request has three purposes (of descending importance):
1) it fixes a hidden issue discovered by anaconda's kickstart tests where the following kickstart snippet
```
logvol swap --name=swap --vgname=fedora --size=500 --fstype=swap
logvol / --name=root --vgname=fedora --size=4000 --grow --fstype=ext4 --cachepvs=pv.2 --cachesize=1000 --cachemode=writethrough
logvol /home --name=home --vgname=fedora --size=1000 --grow --fstype=ext4 --cachepvs=pv.2 --cachesize=1000 --cachemode=writeback
```
results in a successful installation, but the ``swap`` LV ends up being 8 MiB smaller. It's not the end of the world, but if the metadata size for cache was 256 MiB, it would be 256 MiB smaller which is quite a big difference. And even with the 8 MiB it's just wrong because the ``swap`` LV is the only one that has the exact requested size whereas the other LVs are requested to grow and fill in the remaining space.

2) It brings us closer to the target of the issue #31 where similar fixes/improvements/cleanup should happen for other types of LVs too.

3) It brings us closer to the support of LVM cache metadata size specification by users/user code.
-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/207


More information about the anaconda-patches mailing list