[rhinstaller/blivet/pulls/206 rhel7-branch] Add OSError to list of errors in updateSysfsPath (#1252949)

bcl installerbot-noreply at redhat.com
Tue Aug 18 15:39:38 UTC 2015


> @@ -300,7 +300,7 @@ def updateSysfsPath(self):
>          # ValueErrors and EnvironmentErrors that may be raised. So catch
>          # those errors, but also catch DeviceNotFoundError, which is the
>          # appropriate exception and which it may raise in future.
> -        except (pyudev.DeviceNotFoundError, EnvironmentError, ValueError) as e:
> +        except (pyudev.DeviceNotFoundError, EnvironmentError, ValueError, OSError) as e:

> I think we should either add OSError to the comment above the except line make the comment more generic instead of listing all exceptions that may be raised and duplicating the list there.

Yeah, seems silly to list them in the comments.

-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/206#discussion_r37314164


More information about the anaconda-patches mailing list