[rhinstaller/anaconda/pulls/286 master] Translate virtio vendor id into "Virtio Block Device"

vpodzime installerbot-noreply at redhat.com
Thu Aug 13 13:13:02 UTC 2015


> > The changes look good to me, but I'm not really sure this should go into anaconda. Why not blivet?
> 
> @dwlehman and I discussed this on IRC yesterday and decided that this is really a presentation issue that blivet doesn't want to deal with or maintain.

I'm sorry, but I don't really understand the reasoning here. From my point of view, this change/replacement/translation should be done as low as possible. It should ideally be fixed in kernel, but if that's not possible, it should be fixed in blivet. Otherwise every code using blivet (e.g. blivet-gui)  would have to implement something like this proposed function. parted did this for us, but if we no longer use parted, we need to do it. That would also keep things consistent.
-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/286


More information about the anaconda-patches mailing list