[rhinstaller/blivet/pulls/200 rhel7-branch] fcoe: replace fipvlan with fcoemon (#1085325)

rvykydal installerbot-noreply at redhat.com
Wed Aug 12 14:06:25 UTC 2015


> @@ -110,27 +111,69 @@ def addSan(self, nic, dcb=False, auto_vlan=True):
>          log.info("Activating FCoE SAN attached to %s, dcb: %s autovlan: %s",
>                   nic, dcb, auto_vlan)
>  
> -        util.run_program(["ip", "link", "set", nic, "up"])
> -
>          rc = 0
> +        out = ""
> +        timeout = 60
>          error_msg = ""
>          if dcb:
> +
>              self._startLldpad()
> -            util.run_program(["dcbtool", "sc", nic, "dcb", "on"])
> -            util.run_program(["dcbtool", "sc", nic, "app:fcoe",
> -                                                "e:1", "a:1", "w:1"])
> -            rc, out = util.run_program_and_capture_output(["fipvlan", "-c", "-s", "-f",
> -                                               "-fcoe", nic])
> +            while timeout > 0:
> +                rc, out = util.run_program_and_capture_output(
> +                    ["lldptool", "-p"])
> +                if not rc:
> +                    break
> +                log.info("Waiting for lldpad to be ready")

Ah, sorry, actually the patch added is the way I'd go, because eg if the timeout appears in 2nd wile loop, the else branches of the loop *and* all subsequent while loops blocks will get executed.

-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/200#discussion_r36863145


More information about the anaconda-patches mailing list