[master 2/2] Fix crash when new device appear in Welcome screen (#1245960)

jkonecny12 installerbot-noreply at redhat.com
Tue Aug 11 12:34:21 UTC 2015


From: Jiri Konecny <jkonecny at redhat.com>

Anaconda will crash when user add a new device in the Welcome screen.
This happens because the configuration file for the new device wasn't
created.
Fixed by generating this configuration in NetworkSpoke initialization.

Resolves: rhbz#1245960
---
 pyanaconda/ui/gui/spokes/network.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index 372cc10..dac99d2 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -478,6 +478,12 @@ def add_connection_to_list(self, uuid):
         return True
 
     def initialize(self):
+        # There is a signal for newly added devices from NetworkManager but it
+        # is registered after the initialize method.
+        # So if someone adds a new device in the Welcome screen the ifconf file won't
+        # be created which causes anaconda to crash.
+        log.debug("Dump missing interfaces in NetworkControlBox initialize method")
+        network.dumpMissingDefaultIfcfgs()
         for device in self.client.get_devices():
             self.add_device_to_list(device)
 


-- 
To view this commit on github, visit https://github.com/rhinstaller/anaconda/commit/c1d6d594164cb60f1cb49a9e59fb511bc4e118d7


More information about the anaconda-patches mailing list