New: [rhinstaller/anaconda/pulls/74 f22-branch] Fix issues with disk selection changes (#1166598)

vpodzime installerbot-noreply at redhat.com
Thu Apr 16 11:34:54 UTC 2015


**Please ignore the first two commits, those have already been ACKed on the mailing list and just were not pushed to f22-branch yet (I'm waiting for Beta to be declared GO)**

The first of the latter four commits make the ``on_back_clicked`` method of the *StorageSpoke* less complicated  because it has been bloating with if's and duplicated chunks of code for quite some time into the shape that was really hard to understand not even modify. To review this commit I highly recommend to check the result instead of/before going through the changes. The second commit is just a minor change simplifying the logic a bit.

The last two commits implement and use a snapshot of on-disk storage as we get it from scanning disks before we do any modifications so that we can revert everything to it in case user changes their mind about disk selection. The previous "limbo" with hiding/unhiding disks and relying on the result of cancelling actions on the way being the original state of everything was brave, but not working. However, it still is the right thing to do and that's why this PR is only for the f22-branch with quite a bit of hope that action cancelling will have been fixed in blivet by the time of F23.
-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/74


More information about the anaconda-patches mailing list