[rhinstaller/blivet/pulls/71 master] Consolidate common code in DeviceFormat class methods.

vpodzime installerbot-noreply at redhat.com
Wed Apr 8 07:29:17 UTC 2015


> @@ -367,6 +367,15 @@ def create(self, **kwargs):
>          """
>          log_method_call(self, device=self.device,
>                          type=self.type, status=self.status)
> +        self._preCreate(**kwargs)
> +        try:
> +            self._create(**kwargs)
> +        except Exception:
> +            raise

I think the try-except doesn't make sense here. Maybe it had ``finally:`` or ``else:`` where it was taken from (?), but in the form it has here it doesn't make a difference to a plain ``self._create(**kwargs)`` call.

-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/71#discussion_r27948157


More information about the anaconda-patches mailing list