I confirmed with a drive that has both physical and logical 4k sector size that the size attr in sysfs is a count of 512-byte blocks. -- To view this comment on github, visit https://github.com/dwlehman/blivet/commit/ccc7e869c61c0e941352c3a12e85f96361223526#commitcomment-10588374