[blivet][rhel7, master][PATCH] Remove a problematic remnant of singlePV.

Vratislav Podzimek vpodzime at redhat.com
Tue Sep 30 17:29:39 UTC 2014


On Tue, 2014-09-30 at 12:19 -0500, David Lehman wrote:
> Resolves: rhbz#1147985
> ---
>  blivet/deviceaction.py | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/blivet/deviceaction.py b/blivet/deviceaction.py
> index 73af81f..b618b61 100644
> --- a/blivet/deviceaction.py
> +++ b/blivet/deviceaction.py
> @@ -26,7 +26,6 @@ from . import util
>  from . import udev
>  from .devices import StorageDevice
>  from .devices import PartitionDevice
> -from .devices import LVMLogicalVolumeDevice
>  from .formats import getFormat
>  from .storage_log import log_exception_info
>  from parted import partitionFlag, PARTITION_LBA
> @@ -315,11 +314,6 @@ class ActionCreateDevice(DeviceAction):
>              otherNum = action.device.partedPartition.number
>              if selfNum > otherNum:
>                  rc = True
> -        elif (action.isCreate and action.isDevice and
> -              isinstance(self.device, LVMLogicalVolumeDevice) and
> -              isinstance(action.device, LVMLogicalVolumeDevice) and
> -              self.device.vg == action.device.vg):
> -            rc = True
>          elif (action.isAdd and action.container == self.container):
>              rc = True
I think this change deserves a little bit more information in the commit
message, but otherwise it looks good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list