[anaconda:rhel7/master 1/5] Change "if <condition>:" to "else:" for clarity (#1076055)

Vratislav Podzimek vpodzime at redhat.com
Tue Sep 30 16:41:35 UTC 2014


On Wed, 2014-09-24 at 12:27 -0400, mulhern wrote:
> Related: rhbz#1076055
> 
> Signed-off-by: mulhern <amulhern at redhat.com>
> ---
>  pyanaconda/ui/gui/spokes/custom.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
> index 950f2f0..e5202d2 100644
> --- a/pyanaconda/ui/gui/spokes/custom.py
> +++ b/pyanaconda/ui/gui/spokes/custom.py
> @@ -1745,7 +1745,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
>                      else:
>                          self.add_new_selector(device)
>  
> -        if not do_reformat:
> +        else:
I intentionally changed this in the opposite direction when I was
refactoring the Custom spoke. In those days it was "an else: in the
middle of nowhere", but still I think we should at least add a comment
below explaining the meaning of that branch.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list