[blivet] Change the default /boot part on s390x to not be lvm. (#1035201)

Samantha N. Bueno sbueno+anaconda at redhat.com
Mon Sep 29 17:35:56 UTC 2014


On Mon, Sep 29, 2014 at 10:03:13AM -0500, David Lehman wrote:
> On 09/29/2014 07:08 AM, Samantha N. Bueno wrote:
> >Avoid any insidious problems that may result from having /boot on lvm
> >on s390x, and simply change the default partitioning for /boot to be
> >on a partition.
> >
> >Resolves: rhbz#1035201
> >---
> >  blivet/platform.py | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> >diff --git a/blivet/platform.py b/blivet/platform.py
> >index 9b10268..1fd0f12 100644
> >--- a/blivet/platform.py
> >+++ b/blivet/platform.py
> >@@ -336,9 +336,7 @@ class S390(Platform):
> >      def setDefaultPartitioning(self):
> >          """Return the default platform-specific partitioning information."""
> >          return [PartSpec(mountpoint="/boot", size=Size("500MiB"),
> >-                         weight=self.weight(mountpoint="/boot"), lv=True,
> >-                         singlePV=True)]
> >-
> >+                         weight=self.weight(mountpoint="/boot"), lv=False)]
> >      def requiredDiskLabelType(self, device_type):
> >          """The required disklabel type for the specified device type."""
> >          if device_type == parted.DEVICE_DASD:
> >
> 
> I think it's safe to remove all of the singlePV code from blivet since it
> was only ever there for the case of /boot on s390.
 
Actually, I thought of one good reason to leave the singlePV code in--if
a user does not specifically create /boot, then / needs to be on a
singlePV. And while these changes account for /boot, there is no
accounting for /. So unless I am missing something, this should probably
stay in.

> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list