[PATCH master/rhel7] Allow disc swapping with "inst.ks=cdrom[:...]" (#1122104)

Will Woods wwoods at redhat.com
Fri Sep 26 20:43:25 UTC 2014


On Fri, 2014-09-26 at 10:04 -0400, Chris Lumens wrote:
> > So here's a couple patches that will let you swap CDs to load your kickstart
> > off CD if you're also installing off a CD/DVD. I guess people do this
> > sometimes?
> > 
> > I've tested it out locally - yes, I had to dust off my CD-Rs because
> > virt-manager doesn't seem to like you ejecting a virtual CD? Whatever.
> > Anyway it totally works and stuff.
> > 
> > And it *only* triggers if you're using literally "inst.ks=cdrom[:...]" as a
> > boot argument, so it shouldn't affect any other boot paths.
> > 
> > First patch adds some helper functions, the second patch uses them to do
> > stuff.
> 
> Saying "Looks good" seems like a lie, so I'll just say: I don't see any
> problems with this that would prevent it from fixing the bug.

It's bash, man. It's always going to be ugly. Like a toilet seat smoking
a cigar, bash, that is what you are.

OTOH: if you have concerns about functionality / unintended
consequences / etc, I'd be happy to talk more about that?

There *are* a couple of possible corner cases that I didn't bother to
eliminate - like, if you have two CDROM drives, and the kickstart is in
one and the install media is in the other, you might get a spurious
"Please insert installation media..." message right before we mount the
installation media and start the installer.

AFAICT the worst possible failure condition for any of those cases is a
spurious message on the console, so.. I feel pretty good about this
patch.

-w



More information about the anaconda-patches mailing list