[anaconda][rhel7-branch/master][PATCH] Don't crash if escrow certificate is requested without network access (#1085265)
amulhern at redhat.com
Fri Sep 26 16:22:30 UTC 2014
----- Original Message -----
> From: "Chris Lumens" <clumens at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Friday, September 26, 2014 12:01:11 PM
> Subject: Re: [anaconda][rhel7-branch/master][PATCH] Don't crash if escrow certificate is requested without network
> access (#1085265)
> > Unfortunately, our only options are KSValueError, KSVersionError,
> > KSParseError
> > and the situation of no network being available definitely does not match
> > any of them.
> If you're only sticking to pykickstart-provided errors.
> Looking around, I see pyanaconda/packaging/__init__.py provides a
> NoNetworkError exception. How about promoting that up out of packaging
> and raising that error? The name is pretty perfect for the situation
> - Chris
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
The name is nice, but the specifics of promotion seem rather tricky.
Promote it to what, exactly?
The exception in question is being raised while coping with a kickstart,
and the code that calls doKickstartStorage() isn't set up to handle arbitrary exceptions,
or PayloadError exceptions.
More information about the anaconda-patches