[PATCH] When in doubt, use "Done"

Martin Kolman mkolman at redhat.com
Fri Sep 26 12:30:42 UTC 2014

So after digging through the horrendous Firstboot source code,
it looks like there is indeed no way to check if a page of a given
firstboot multi-page module is the last or not...

This probably did not surface earlier as the multi page modules, such
as Subscription Manager, were probably followed by a single page module,
so all their pages just had a "Forward" label on their next-button and
everything was fine. On the other hand, we will soon have the Subscription
Manager module as the only Firstboot module since the KDUMP plugin has been
converted to an Anaconda addon.

As there does not seem to be any straightforward solution without changes to
both the module interface and to the Subscription Manager module (and any other
multi-page modules), I've done the only think that can in my opinion improve the
current situation at least a bit, and that is I've changed the label for all pages
of the last (or only) module from "Finished" to "Done", as clicking "Done" a few
times makes more sense than clicking "Finish" multiple times.

Martin Kolman (1):
  Replace Finish with Done on the next button (#1107887)

 firstboot/interface.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


More information about the anaconda-patches mailing list