[anaconda][rhel7-branch][PATCH 0/2] Help for every screen

Martin Kolman mkolman at redhat.com
Thu Sep 25 17:37:12 UTC 2014


This is the rhel7-branch version of the help patchset. A couple of things to note:
* I've left out the patches that bind the F1 key to trigger the help viewer for
  the current screen + the custom mnemonics patches, as the mechanism used for this on master
  does not exist on rhel7-branch and so these patches will most probably require some
  quite extensive changes
* in the same spirit as how the master version of this patch set bumps the widgets version to 3.1,
  I've bumped it to 1.1 for RHEL7 branch - is this correct & correctly done ?
* I've tested that the help buttons work correctly on the Welcome spoke, on the hub, in spokes and
  even inside the KDUMP addon :)
* unfortunately this does not hold for the DATE & TIME spoke - once you enter it, you get black screen
  and anaconda crashes hard (pane-is-dead hard) and there is this error message on TTY1:

(anaconda:1467): Glib-ERROR **: gmem.c:335: overflow allocating 18446744073709551615*18446744073709551615 bytes

- this error message does not show up when running without updates image & the DATE & TIME spoke does not crash,
  so it is very likely related to the crash
- there is nothing related in the anaconda.log
- might this be related to the world-map widget & widgets versioning ?
- Any help with debugging this issue would be very appreciated, thanks in advance! :)

Martin Kolman (2):
  Add a help button to every Anaconda screen
  Specify help file names for hubs and spokes

 anaconda.spec.in                                |   1 +
 data/help/Makefile.am                           |  21 ++++
 data/help/en-US/FedoraPlaceholder.html          |   5 +
 data/help/en-US/FedoraPlaceholderWithLinks.html |  13 +++
 data/help/en-US/Makefile.am                     |  23 ++++
 data/help/en-US/RHEL7Placeholder.html           |   5 +
 data/help/en-US/RHEL7PlaceholderWithLinks.html  |  11 ++
 pyanaconda/ihelp.py                             | 143 ++++++++++++++++++++++++
 pyanaconda/installclass.py                      |   6 +
 pyanaconda/installclasses/fedora.py             |   3 +
 pyanaconda/installclasses/rhel.py               |   3 +
 pyanaconda/ui/gui/__init__.py                   |  12 ++
 pyanaconda/ui/gui/hubs/__init__.py              |   4 +-
 pyanaconda/ui/gui/hubs/progress.py              |   1 +
 pyanaconda/ui/gui/hubs/summary.py               |   1 +
 pyanaconda/ui/gui/spokes/__init__.py            |  13 ++-
 pyanaconda/ui/gui/spokes/custom.py              |   1 +
 pyanaconda/ui/gui/spokes/datetime_spoke.py      |   1 +
 pyanaconda/ui/gui/spokes/filter.py              |   1 +
 pyanaconda/ui/gui/spokes/keyboard.py            |   1 +
 pyanaconda/ui/gui/spokes/langsupport.py         |   1 +
 pyanaconda/ui/gui/spokes/network.py             |   1 +
 pyanaconda/ui/gui/spokes/password.py            |   1 +
 pyanaconda/ui/gui/spokes/software.py            |   1 +
 pyanaconda/ui/gui/spokes/source.py              |   1 +
 pyanaconda/ui/gui/spokes/storage.py             |   1 +
 pyanaconda/ui/gui/spokes/user.py                |   1 +
 pyanaconda/ui/gui/spokes/welcome.py             |   1 +
 scripts/makeupdates                             |   3 +
 widgets/configure.ac                            |   4 +-
 widgets/glade/AnacondaWidgets.xml               |   7 +-
 widgets/src/BaseWindow.c                        |  48 ++++++++
 widgets/src/BaseWindow.h                        |   3 +
 33 files changed, 337 insertions(+), 5 deletions(-)
 create mode 100644 data/help/Makefile.am
 create mode 100644 data/help/en-US/FedoraPlaceholder.html
 create mode 100644 data/help/en-US/FedoraPlaceholderWithLinks.html
 create mode 100644 data/help/en-US/Makefile.am
 create mode 100644 data/help/en-US/RHEL7Placeholder.html
 create mode 100644 data/help/en-US/RHEL7PlaceholderWithLinks.html
 create mode 100644 pyanaconda/ihelp.py

-- 
1.9.3



More information about the anaconda-patches mailing list