[PATCH blivet/master 3/3] Disable LVM autobackup when doing image installs (#1066004)

Anne Mulhern amulhern at redhat.com
Mon Sep 22 12:24:55 UTC 2014





----- Original Message -----
> From: "Anne Mulhern" <amulhern at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Monday, September 22, 2014 8:19:29 AM
> Subject: Re: [PATCH blivet/master 3/3] Disable LVM autobackup when doing	image	installs (#1066004)
> 
> 
> 
> 
> 
> ----- Original Message -----
> > From: "Will Woods" <wwoods at redhat.com>
> > To: anaconda-patches at lists.fedorahosted.org
> > Sent: Friday, September 19, 2014 6:18:38 PM
> > Subject: [PATCH blivet/master 3/3] Disable LVM autobackup when doing image
> > 	installs (#1066004)
> > 
> > If we're doing an image install, the host system doesn't really care
> > about the metadata for these volume groups - and if you do a lot of
> > image installs (say, on a build system) the archive/ directory is going
> > to grow without bound.
> > 
> > So: suppress the autobackup behavior during image installs to prevent
> > modifying things on the host.
> > ---
> >  blivet/platform.py | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/blivet/platform.py b/blivet/platform.py
> > index 1ab09e4..5261bfa 100644
> > --- a/blivet/platform.py
> > +++ b/blivet/platform.py
> > @@ -71,6 +71,9 @@ class Platform(object):
> >                  log.warn("GPT is not a supported disklabel on this
> >                  platform.
> >                  Using default "
> >                           "disklabel %s instead.",
> >                           self.defaultDiskLabelType)
> 
> An explanatory comment right here, containing much the same info as the
> commit message,
> would be great.
> 
> >  
> > +        if flags.image_install:
> > +            devicelibs.lvm.autobackup = False
> > +
> >      def __call__(self):
> >          return self
> >  
> > --
> > 1.9.3
> > 
> > _______________________________________________
> > anaconda-patches mailing list
> > anaconda-patches at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > 
> 
> - mulhern
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Also, blivet has its own flags class, it might be better to make a flag in that class
and use it in devicelibs/lvm.py than to make it there. There's already an
allow_degraded_mdraid flag in flags.py, so there is already precedent for putting
device type specific flags in flags.py.

- mulhern


More information about the anaconda-patches mailing list