[PATCH blivet/master] devicelibs.lvm: fix pvmove(src, dest=DESTPATH)

Anne Mulhern amulhern at redhat.com
Mon Sep 22 11:48:46 UTC 2014





----- Original Message -----
> From: "Will Woods" <wwoods at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Friday, September 19, 2014 3:11:41 PM
> Subject: [PATCH blivet/master] devicelibs.lvm: fix pvmove(src, dest=DESTPATH)
> 
> args.extend(str) will treat the str as iterable and append each
> individual character to args; should be args.append(str).
> ---
>  blivet/devicelibs/lvm.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/blivet/devicelibs/lvm.py b/blivet/devicelibs/lvm.py
> index 426794f..87d2639 100644
> --- a/blivet/devicelibs/lvm.py
> +++ b/blivet/devicelibs/lvm.py
> @@ -261,7 +261,7 @@ def pvmove(source, dest=None):
>      """
>      args = ["pvmove"] + _getConfigArgs() + [source]
>      if dest:
> -        args.extend(dest)
> +        args.append(dest)
>  
>      try:
>          lvm(args)
> --
> 1.9.3
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Would be helpful to toss in a test in tests/devicelibs/lvm_test.py.

Probably the best place is in a new method in LVMAsRootTestCase class.

- mulhern


More information about the anaconda-patches mailing list