[pykickstart][PATCH] Add support for specifying thin pool profile

Vratislav Podzimek vpodzime at redhat.com
Fri Sep 19 18:49:13 UTC 2014


On Fri, 2014-09-19 at 10:37 -0400, Chris Lumens wrote:
> > +class RHEL7_LogVolData(F20_LogVolData):
> > +    def __init__(self, *args, **kwargs):
> > +        F20_LogVolData.__init__(self, *args, **kwargs)
> > +        self.profile = kwargs.get("profile", "")
> > +
> > +    def _getArgsAsStr(self):
> > +        retval = F20_LogVolData._getArgsAsStr(self)
> > +
> > +        if self.profile:
> > +            retval += " --profile=%s" % self.profile
> > +
> > +        return retval
> > +
> 
> Is it possible we will one day want to add something else to the logvol
> command that could be named "profile"?  I feel the current option name
> is too generic and we'll regret it later.
Not much possible, as the '--profile' option is a generic option for the
'lvm' command documented in lvm (8). Thus I think it won't be ever used
for anything else.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list