[anaconda:rhel7/master 0/2] #1076055 patches
dlehman at redhat.com
Fri Sep 19 14:39:34 UTC 2014
On 09/19/2014 08:45 AM, Anne Mulhern wrote:
> ----- Original Message -----
>> From: "David Lehman" <dlehman at redhat.com>
>> To: anaconda-patches at lists.fedorahosted.org
>> Sent: Thursday, September 18, 2014 6:39:21 PM
>> Subject: Re: [anaconda:rhel7/master 0/2] #1076055 patches
>> On 09/16/2014 12:26 PM, mulhern wrote:
>>> These patches are both optional assuming the blivet patch is correct.
>>> The first is almost independent, and fixes a small bug that omitted
>>> to check whether maxSize was 0 (indicating no maxSize).
>>> The other makes use_dev a little less used in _save_right_side as
>>> part of an overall goal of handling these kinds of distinctions in
>>> blivet wherever that is appropriate.
>> Does this mean we'd be scheduling resize actions on non-existent LUKS
>> devices? Please say no. I don't think I can stomach that.
>>> mulhern (2):
>>> Handle case where device.maxSize is 0 differently (#1076055)
>>> Make resizable and exists based on device, not use_dev (#1076055)
>>> pyanaconda/ui/gui/spokes/custom.py | 25 ++++++++++++++++---------
>>> 1 file changed, 16 insertions(+), 9 deletions(-)
>> anaconda-patches mailing list
>> anaconda-patches at lists.fedorahosted.org
> I'm bewildered because on Monday you told me:
> "If the LUKS is preexisting the device cannot be resized."
> "If the device is going to be reformatted and newly encrypted it can be resized. (Assuming it is of a resizable type, eg: partition, lv)"
> I'm unable to make sense of all three statements at once.
Sorry -- I can see how that was confusing. By "can be resized" I meant
"the size field can be changed in the GUI". When it comes to actually
resizing things, only existing devices can be resized. The challenge is
properly converting the GUI data into a reasonable set of actions.
> - mulhern
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
More information about the anaconda-patches