[pykickstart][PATCH] Add support for specifying thin pool profile

Chris Lumens clumens at redhat.com
Fri Sep 19 14:37:42 UTC 2014


> +class RHEL7_LogVolData(F20_LogVolData):
> +    def __init__(self, *args, **kwargs):
> +        F20_LogVolData.__init__(self, *args, **kwargs)
> +        self.profile = kwargs.get("profile", "")
> +
> +    def _getArgsAsStr(self):
> +        retval = F20_LogVolData._getArgsAsStr(self)
> +
> +        if self.profile:
> +            retval += " --profile=%s" % self.profile
> +
> +        return retval
> +

Is it possible we will one day want to add something else to the logvol
command that could be named "profile"?  I feel the current option name
is too generic and we'll regret it later.

Aside from that, the pykickstart portion looks fine.

- Chris


More information about the anaconda-patches mailing list