[PATCH] Reorganize the right side of the Custom spoke (#1094856)

Vratislav Podzimek vpodzime at redhat.com
Thu Sep 18 14:59:55 UTC 2014


On Thu, 2014-09-18 at 10:43 -0400, Chris Lumens wrote:
> > diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
> > @@ -1844,6 +1846,18 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
> >  
> >          return device_type
> >  
> > +    def _set_devices_label(self):
> > +        device_disks = self._device_disks
> > +        if not device_disks:
> > +            devices_desc = _("No disks assigned")
> > +        else:
> > +            devices_desc = "%s (%s)" % (device_disks[0].description, device_disks[0].name)
> > +            num_disks = len(device_disks)
> > +            if num_disks > 1:
> > +                devices_desc += P_(" and %d other" % (num_disks - 1), " and %d others" % (num_disks -1 ),
> > +                                   num_disks - 1)
> 
> I believe P_() works the same way as the other translation functions in
> that you should do the substitution outside of the call.
Good catch, fixing locally. Thanks!

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list