[master/rhel7-branch] Fix the way zFCP devices are displayed in storage spoke. (#1024902)

Samantha N. Bueno sbueno+anaconda at redhat.com
Thu Sep 18 14:37:25 UTC 2014


On Thu, Sep 18, 2014 at 10:26:21AM -0400, Chris Lumens wrote:
> > @@ -603,6 +603,10 @@ class StorageSpoke(NormalSpoke, StorageChecker):
> >          if isinstance(disk, MultipathDevice):
> >              desc = disk.wwid.split(":")
> >              description = ":".join(desc[0:3]) + "..." + ":".join(desc[-4:])
> > +        elif isinstance(disk, ZFCPDiskDevice):
> > +            # manually mangle the desc of a zFCP device to be multi-line since
> > +            # it's so long it makes the disk selection screen look odd
> > +            description = _("FCP device %s\nWWPN %s\nLUN %s" % (disk.hba_id, disk.wwpn, disk.fcp_lun))
> 
> Change this to do the string substitution outside the call to _().

One day I will not have to be reminded of this. Thanks for catching,
fixed locally.
 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list