[blivet:master] Remove test which needs updating on btrfs-progs version change.
Anne Mulhern
amulhern at redhat.com
Wed Sep 17 15:16:05 UTC 2014
----- Original Message -----
> From: "mulhern" <amulhern at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Cc: "mulhern" <amulhern at redhat.com>
> Sent: Wednesday, September 17, 2014 8:09:14 AM
> Subject: [blivet:master] Remove test which needs updating on btrfs-progs version change.
>
> mkfs.btrfs v3.16 calls any device smaller than 16 GiB too small, previously
> the device had to be smaller than 8 GiB to be "too small".
>
> This test is too brittle to keep around and it does not test any fact that
> is relied on by our code, so it should go.
>
> Signed-off-by: mulhern <amulhern at redhat.com>
> ---
> tests/devicelibs_test/btrfs_test.py | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/tests/devicelibs_test/btrfs_test.py
> b/tests/devicelibs_test/btrfs_test.py
> index dcf1bcd..dae3f07 100755
> --- a/tests/devicelibs_test/btrfs_test.py
> +++ b/tests/devicelibs_test/btrfs_test.py
> @@ -161,19 +161,5 @@ class BTRFSAsRootTestCase2(BTRFSMountDevice):
> subvolumes = btrfs.list_subvolumes(self.mountpoint)
> self.assertEqual(len([v for v in subvolumes if
> v['path'].find("SV1.1") != -1]), 1)
>
> -class BTRFSAsRootTestCase3(loopbackedtestcase.LoopBackedTestCase):
> -
> - def __init__(self, methodName='runTest'):
> - super(BTRFSAsRootTestCase3, self).__init__(methodName=methodName,
> deviceSpec=[8192])
> -
> - def testSmallDevice(self):
> - """ Creation of a smallish device will result in an error if the
> - data and metadata levels are specified differently, but not if
> - they are unspecified.
> - """
> - with self.assertRaises(BTRFSError):
> - btrfs.create_volume(self.loopDevices, data="single",
> metadata="dup")
> - self.assertEqual(btrfs.create_volume(self.loopDevices), 0)
> -
> if __name__ == "__main__":
> unittest.main()
> --
> 1.9.3
>
>
Actually, btrfs is not as greedy as I made it out to be, it needs 16 MiB now, not
16 GiB. Fixed comment in working copy.
- mulhern
More information about the anaconda-patches
mailing list