[PATCH 1/2] Add a help button to every Anaconda screen

Martin Kolman mkolman at redhat.com
Wed Sep 17 09:36:54 UTC 2014

On Tue, 2014-09-16 at 13:56 -0400, Chris Lumens wrote:
> > @@ -109,6 +112,7 @@ enum {
> >  #define DEFAULT_BETA          N_("PRE-RELEASE / TESTING")
> > +#define HELP_BUTTON_LABEL _("_Help!")
> >  
> >  struct _AnacondaBaseWindowPrivate {
> >      gboolean    is_beta, info_shown;
> I hate to drag things out more, but I can't help but think _H on every
> screen has the opportunity to conflict with a lot of other buttons.
> This is guaranteed on storage (see Radek's patch from earlier), so
> taking away a letter is going to result in real difficulties on that
> screen.
Sure, I'll dump the _H accelerator then. BTW, how do we handle/check
accelerators for translated button labels ? For example in Czech
where the label "Done" is translated as "Hotovo", the H letter (_Hotovo)
is used as accelerator, which seems rather arbitrary (_Done ->
_Hotovo ?).

> Brian suggests F1 is a good key to pull up help, given that it's
> frequently a help key elsewhere (and has the distinct advantage of not
> being a letter), though I think it may be weird to have a button that
> doesn't have an underlined letter on it.  He then suggests "Help (F1)".
Well, I think that the "Help (F1)" label would be rather ugly & no other
button in Anaconda has a shortcut displayed on it at all times AFAIK.
Also the F1 shortcut is indeed very widely used, so I think it really
doesn't need to be presented so prominently on the button itself.

> Also, I think it needs to be N_() in the #define, though I could be
> misremembering things.  All the others are though.
Will do, thanks for noting! :)

> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches

More information about the anaconda-patches mailing list