[PATCH 3/3] Short-circuit Storage spoke leaving when no changes were done

Vratislav Podzimek vpodzime at redhat.com
Wed Sep 17 05:51:09 UTC 2014

On Tue, 2014-09-16 at 14:52 -0500, David Lehman wrote:
> On 09/16/2014 01:18 PM, Vratislav Podzimek wrote:
> > On Tue, 2014-09-16 at 11:48 -0400, Chris Lumens wrote:
> >>> This doesn't take into account the possibility that the user wants to redo
> >>> custom storage without changing any of the settings on the main storage
> >>> spoke. Otherwise I like this one.
> >>
> >> And in fact, there is a comment to this effect in storage.py:
> >>
> >>      def on_back_clicked(self, button):
> >>          # We can't exit early if it looks like nothing has changed because the
> >>          # user might want to change settings presented in the dialogs shown from
> >>          # within this method.
> > The only use case that comes to my mind is if user wants to reclaim some
> > more space, but okay, dropping this patch.
> Maybe you can just add 'or self._reclaim.get_active()' to the same if 
> statement you added 'or self._customPart.get_active()' to instead of 
> dropping the patch completely.
Oh, you're right, that would still help at least a bit. It would at
least short-circuit the easiest case where user enters the spoke again
with the same disk selection, no reclaim requests and autopart selected.
Tweaking, keeping and pushing. Thanks, guys!

Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic

More information about the anaconda-patches mailing list