[PATCH 3/3] Short-circuit Storage spoke leaving when no changes were done

Vratislav Podzimek vpodzime at redhat.com
Tue Sep 16 18:18:57 UTC 2014


On Tue, 2014-09-16 at 11:48 -0400, Chris Lumens wrote:
> > This doesn't take into account the possibility that the user wants to redo
> > custom storage without changing any of the settings on the main storage
> > spoke. Otherwise I like this one.
> 
> And in fact, there is a comment to this effect in storage.py:
> 
>     def on_back_clicked(self, button):
>         # We can't exit early if it looks like nothing has changed because the
>         # user might want to change settings presented in the dialogs shown from
>         # within this method.
The only use case that comes to my mind is if user wants to reclaim some
more space, but okay, dropping this patch.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list