[PATCH rhel7-branch/master] Apply a better check for whether to fail if authconfig is missing.
vpodzime at redhat.com
Tue Sep 16 18:12:45 UTC 2014
On Tue, 2014-09-16 at 11:14 -0400, Chris Lumens wrote:
> The previous check is incorrect for one big reason: I only tested it on
> kickstart installs, where I had control over everything and left out the
> authconfig command. Interactive installs, however, have their defaults
> set by a kickstart file that includes authconfig. So all interactive
> installs always have ksdata.auth.seen set which then causes the traceback
> to be raised.
> Resolves: rhbz#1140640
> pyanaconda/kickstart.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py
> index 9898135..d427b04 100644
> --- a/pyanaconda/kickstart.py
> +++ b/pyanaconda/kickstart.py
> @@ -242,7 +242,7 @@ class Authconfig(commands.authconfig.FC3_Authconfig):
> def execute(self, *args):
> cmd = "/usr/sbin/authconfig"
> if not os.path.lexists(iutil.getSysroot()+cmd):
> - if self.seen:
> + if flags.automatedInstall and self.seen:
> msg = _("%s is missing. Cannot setup authentication.") % cmd
> raise KickstartError(msg)
Looks good to me.
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches