[PATCH 1/2] Add a help button to every Anaconda screen

Chris Lumens clumens at redhat.com
Tue Sep 16 17:56:02 UTC 2014


> @@ -109,6 +112,7 @@ enum {
>  #define DEFAULT_WINDOW_NAME   N_("SPOKE NAME")
>  #define DEFAULT_BETA          N_("PRE-RELEASE / TESTING")
>  #define LAYOUT_INDICATOR_LABEL_WIDTH 10
> +#define HELP_BUTTON_LABEL _("_Help!")
>  
>  struct _AnacondaBaseWindowPrivate {
>      gboolean    is_beta, info_shown;

I hate to drag things out more, but I can't help but think _H on every
screen has the opportunity to conflict with a lot of other buttons.
This is guaranteed on storage (see Radek's patch from earlier), so
taking away a letter is going to result in real difficulties on that
screen.

Brian suggests F1 is a good key to pull up help, given that it's
frequently a help key elsewhere (and has the distinct advantage of not
being a letter), though I think it may be weird to have a button that
doesn't have an underlined letter on it.  He then suggests "Help (F1)".

Also, I think it needs to be N_() in the #define, though I could be
misremembering things.  All the others are though.

- Chris


More information about the anaconda-patches mailing list