[master/rhel7-branch] Fix an issue with bad NFS info specified in source spoke. (#1097432)

Samantha N. Bueno sbueno+anaconda at redhat.com
Tue Sep 16 13:59:08 UTC 2014


On Tue, Sep 16, 2014 at 07:33:59AM -0400, Anne Mulhern wrote:
> ----- Original Message -----
> > From: "Samantha N. Bueno" <sbueno+anaconda at redhat.com>
> > To: anaconda-patches at lists.fedorahosted.org
> > Sent: Monday, September 15, 2014 3:22:08 PM
> > Subject: [master/rhel7-branch] Fix an issue with bad NFS info specified in	source spoke. (#1097432)
> > 
> > If an NFS repo was specified as 10.0.0.1/example/dir, it would be
> > interpreted as HTTP. Instead of returning if no ':' is detected in
> > the address, this just continues and lets the ValueError get raised
> > when the url can't be split and displays an error to the user that
> > there was a problem setting up the source repo. No more mix-up with
> > it being HTTP either.
> > 
> > Resolves: rhbz#1097432
> > ---
> >  pyanaconda/ui/gui/spokes/source.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/pyanaconda/ui/gui/spokes/source.py
> > b/pyanaconda/ui/gui/spokes/source.py
> > index d1ce6a1..c9705a2 100644
> > --- a/pyanaconda/ui/gui/spokes/source.py
> > +++ b/pyanaconda/ui/gui/spokes/source.py
> > @@ -396,7 +396,7 @@ class SourceSpoke(NormalSpoke):
> >              # If the user didn't fill in the URL entry, or it does not
> >              contain
> >              # a ':' (so, no host/directory split), just return as if they
> >              # selected nothing.
> > -            if url == "" or not ':' in url:
> > +            if url == "":
> >                  return False
> >  
> >              self.data.method.method = "nfs"
> > --
> > 1.9.3
> > 
> > _______________________________________________
> > anaconda-patches mailing list
> > anaconda-patches at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > 
> 
> Comment above should be updated to match code, my preference
> would be to get rid of it entirely.

Whoops, yes it should; I'm fine with killing it as well.
 
> - mulhern
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list