[PATCH] add capability to install grub2 but not update the MBR

David Lehman dlehman at redhat.com
Tue Sep 16 13:37:02 UTC 2014


On 09/15/2014 08:26 AM, Gene Czarcinski wrote:
> On 09/15/2014 08:59 AM, Vratislav Podzimek wrote:
>> On Mon, 2014-09-15 at 08:54 -0400, Gene Czarcinski wrote:
>>> >On 09/15/2014 02:30 AM, Vratislav Podzimek wrote:
>>>> > >Where is the kickstart support? Or do you by "Kickstart install"
>>>> mean
>>>> > >installation where both 'ks=...' and 'inst.nombr' are provided as
>>>> boot
>>>> > >options? I think we still need something like 'bootloader
>>>> --nombr' if
>>>> > >this is the right way to go to fix that bug.
>>>> > >
>>>> > >
>>> >I decided to keep things as simple as possible and just have to boot
>>> >parameter "nombr" which will apply to any install including kickstart.
>>> >I did consider adding code so that like --extlinux, you could specify
>>> >--nombr on kickstart's bootloader command.  But, more code is a chance
>>> >for additional errors.
>>> >
>>> >But, if there is a strong desire to have --nombr as another option on
>>> >kickstart's bootloader command, I can add it.
>> A general policy in the Anaconda installer is that every feature should
>> be implemented in kickstart first. That's the most comprehensive and
>> feature-complete "installation mode". So please add that code as well.
> v1.1 coming "real soon now"
>
> Since you brought up the fact that it is Anaconda Installer policy that
> every feature be implemented in kickstart first, how about my kickstart
> "--reclaim" option for kickstart's btrfs command.


Gene, I know we've been over this at least twice already. First, there 
is no equivalent to your proposed --reclaim option for any other device 
type. Second, there are two existing ways to achieve what you want:

1) Use a new name for the new subvolume
2) "reclaim" the old subvolume using 'clearpart --list=root1'

Please stop pushing this patch as it offers nothing new except more code 
to maintain.

David

>
> The problem:  When I manually configure the storage layouts on a regular
> gui or live install, one of the things I can do is to delete an existing
> subvolume so that the space and the subvolume's name can be reused.  In
> kickstart, currently I can one create new subvolumes or re-use an
> existing subvolume.  There is also the requirement that the the rootfs
> ("/") subvolume always be freshly "formatted".
>
> So, to provide the same capability to kickstart that is available in a
> regular install, I create a "reclaim" patch.  With the patch applied,
> you can specify something like:
>           btrfs  /           --subvol  --name=root1  btrfs_vol --reclaim
>           btrfs  /home  --subvol  --name=home  btrfs_vol  --noformat
>
> which will result in two subvolume.  The home subvolume is reused
> whereas if the root1 subvolume already exists, it will be deleted and
> then reallocated.
>
> Comments??
>
> Gene
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches



More information about the anaconda-patches mailing list