[blivet:rhel7-master] Remove poolMetaData (#1021505)

mulhern amulhern at redhat.com
Tue Sep 16 12:09:41 UTC 2014


It is never anything but 0, and is only used in addition or subtraction
expression and 0 is the identity for these operations.

It was added in commit 8ef070b7b6fe4f270cc0120e5425299abf90b8cd (2013/10/07).
Its last set was removed in commit 6897f50181662d91d1b6c84e749afe3ec48d2310
(2013/11/1).

It does not seem to have ever been used in anaconda, and it does not exist
in pykickstart.

Signed-off-by: mulhern <amulhern at redhat.com>
---
 blivet/devices.py | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/blivet/devices.py b/blivet/devices.py
index 7e4279c..5281d30 100644
--- a/blivet/devices.py
+++ b/blivet/devices.py
@@ -2468,9 +2468,6 @@ class LVMVolumeGroupDevice(ContainerDevice):
         self.reserved_percent = 0
         self.reserved_space = Size(0)
 
-        # this will have to be covered by the 20% pad for non-existent pools
-        self.poolMetaData = 0
-
         # TODO: validate peSize if given
         if not self.peSize:
             self.peSize = lvm.LVM_PE_SIZE
@@ -2642,9 +2639,6 @@ class LVMVolumeGroupDevice(ContainerDevice):
 
         self._lvs.remove(lv)
 
-        if self.poolMetaData and not self.thinpools:
-            self.poolMetaData = 0
-
         # snapshot accounting
         origin = getattr(lv, "origin", None)
         if origin:
@@ -2737,7 +2731,6 @@ class LVMVolumeGroupDevice(ContainerDevice):
             new_lvs = [lv for lv in self.lvs if not lv.exists]
             used += len(new_lvs) * 5 * raid_disks * self.peSize
         used += self.reservedSpace
-        used += self.poolMetaData
         free = self.size - used
         log.debug("vg %s has %s free", self.name, free)
         return free
-- 
1.9.3



More information about the anaconda-patches mailing list