[PATCH 2/3] Apply changes in disk selection even if not reclaiming space
vpodzime at redhat.com
Tue Sep 16 07:07:17 UTC 2014
On Mon, 2014-09-15 at 13:05 -0500, David Lehman wrote:
> On 09/11/2014 09:05 AM, Vratislav Podzimek wrote:
> > If we don't run any dialog and user didn't requested reclaiming space we should
> > still apply disk selection in the Storage spoke.
> > Related: rhbz#1085201
> > Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> > ---
> > pyanaconda/ui/gui/spokes/storage.py | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py
> > index 220bb14..2a48fca 100644
> > --- a/pyanaconda/ui/gui/spokes/storage.py
> > +++ b/pyanaconda/ui/gui/spokes/storage.py
> > @@ -823,9 +823,10 @@ class StorageSpoke(NormalSpoke, StorageChecker):
> > if not self._check_encrypted():
> > return
> > + self.apply()
> > +
> > # Oh and then we might also want to go to the reclaim dialog.
> > if self._reclaim.get_active():
> > - self.apply()
> > if not self._show_resize_dialog(disks):
> > # User pressed cancel on the reclaim dialog, so don't leave
> > # the storage spoke.
> This is likely to expose a pile of bugs related to how we handle custom
> storage and kickstart, some of which I started fixing last week. Since
> this set overlaps with what I'm working on I'll see how these fit with
> what I'm doing by applying them and seeing how much of my progress it
> undoes. I'll report back once I have more information. I like patches 2
> and 3, but I'm unsure about patch 1 as far as handling multiple trips
> into the storage spoke when autopart is selected.
That's what I tested and tried to fix. As we discussed on IRC Anaconda
should not directly remove devices outside of the "actions management"
because those devices were created together with their CreateDevice
actions and should be removed as part of their actions' cancellation.
Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches