[PATCH 0/2] Fix SIGSEGV handler and other synchronous signals

Vratislav Podzimek vpodzime at redhat.com
Mon Sep 15 14:03:52 UTC 2014


On Mon, 2014-09-15 at 09:27 -0400, David Shea wrote:
> On 09/15/2014 02:24 AM, Vratislav Podzimek wrote:
> > On Fri, 2014-09-12 at 16:12 -0400, Chris Lumens wrote:
> >>> Ever noticed that the SIGSEGV handler never actually gets called?
> >> Now that you mention it, yeah.  I was curious what was happening there.
> > I've seen it being called, resulting in a nother SIGSEGV. :)
> >
> > Looks good to me as well.
> >
> 
> Oh wow, really? In light of that, I think it'd be a good idea to undo 
> the part where I took out
> 
> -    signal(SIGSEGV, SIG_DFL); /* back to default */
> 
> Since if we keep that in, a crash in the signal handler will just crash anaconda all the way instead of getting stuck in a signal handler loop. And I guess I should add a comment to that effect.
Maybe, but with that line in, it got stuck in sigsegv-loop. Do you think
that would work with your changes? I think the reason for that loop was
Python code doing things you really shouldn't/cannot do in a SIGSEGV
handler.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list