[master/f21-branch][PATCHv3] split on _ not - when deriving $releasever from productVersion

Adam Williamson awilliam at redhat.com
Thu Sep 11 21:15:20 UTC 2014


On Thu, 2014-09-11 at 10:13 -0700, Adam Williamson wrote:

> > >> Not to make this patch take longer than it needs to, but maybe we should
> > >> just take the digit part of the version and throw out the rest? Then releng
> > >> can change the divider to whatever they please and we don't have to care
> > >> until they change it to something *really* stupid.
> > >>
> > >> Something like, version =  re.match('([\d.]+)', productVersion).group(1)
> > > RHEL uses X.Y for versions.
> > >
> > 
> > Which is why I included a dot in the regex ;-)
> 
> That's fine by me (I'm assuming your regex works, I suck at regex) but
> whatever we do, can we do it now?

For the record (in case anyone comes looking through archives and
wonders what happened to this patch): this was addressed with a regex as
suggested by David, ultimately implemented by bcl, as commit
b900a9e9325e1fb31198ac2d1cc5417c7e922e99 (on master) "Use only the
digits from productVersion".
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net



More information about the anaconda-patches mailing list