[master][PATCH] Specify thin pool metadata/chunk size only if given by user (#1140635)

Vratislav Podzimek vpodzime at redhat.com
Thu Sep 11 14:12:08 UTC 2014


On Thu, 2014-09-11 at 09:59 -0400, Chris Lumens wrote:
> > diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py
> > index f953cc9..eb86461 100644
> > --- a/pyanaconda/kickstart.py
> > +++ b/pyanaconda/kickstart.py
> > @@ -928,11 +928,12 @@ class LogVolData(commands.logvol.F20_LogVolData):
> >              else:
> >                  parents = [vg]
> >  
> > +            pool_args = {}
> >              if self.thin_pool:
> > -                pool_args = { "metadatasize": Size("%d MiB" % self.metadata_size),
> > -                              "chunksize": Size("%d KiB" % self.chunk_size) }
> > -            else:
> > -                pool_args = {}
> > +                if self.metadata_size:
> > +                    pool_args["metadatasize"] =  Size("%d MiB" % self.metadata_size)
> > +                if self.chunk_size:
> > +                    pool_args["chunksize"] = Size("%d KiB" % self.chunk_size)
> >  
> >              if self.maxSizeMB:
> >                  try:
> 
> Assuming these arguments do not need to be marked as required in
> pykickstart, ACK to this patch.
Since they cannot be specified in the GUI I think there are some
defaults.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list