[blivet:rhel7/master 4/4] Fix comment on online_dasd (#1070115)
Vratislav Podzimek
vpodzime at redhat.com
Thu Sep 11 09:15:15 UTC 2014
On Mon, 2014-09-08 at 15:25 -0400, mulhern wrote:
> Related: rhbz#1070115
>
> online_dasd will not find the device unless the number is correctly formatted,
> on the other hand, if the number is not correctly formatted, it simply will not
> find the device.
>
> Signed-off-by: mulhern <amulhern at redhat.com>
> ---
> blivet/devicelibs/dasd.py | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/blivet/devicelibs/dasd.py b/blivet/devicelibs/dasd.py
> index b24add7..70ee748 100644
> --- a/blivet/devicelibs/dasd.py
> +++ b/blivet/devicelibs/dasd.py
> @@ -135,9 +135,10 @@ def sanitize_dasd_dev_input(dev):
> def online_dasd(dev):
> """ Given a device number, switch the device to be online.
>
> - :param dev: string representing a DASD device number; acceptable formats
> - include 0.0.abcd, 0.0.ABCD, abcd, ABCD, where 'abcd' are
> - hexadecimal numbers.
> + :param str dev: a string representing a DASD device number
I think the original indentation was what we use more often.
> +
> + Raises a ValueError if the device with that number does not exist,
> + is already online, or can not be put online.
There is a ':raises:' field so we should use it instead.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list