[PATCH] split on _ not - when deriving $releasever from productVersion
awilliam at redhat.com
Wed Sep 10 22:40:13 UTC 2014
On Wed, 2014-09-10 at 18:01 -0400, Anne Mulhern wrote:
> Maybe better to split on "-" and "_" so that if they change their
> minds again it'll still work.
Well a) it's written down in a policy now so it's TOTALLY not going to
change ;), and b) I didn't know the right way to do that :) Do you just
run the string through split twice, or is there something clever? AFAICS
you can't pass multiple alternate separator fields with str.split, but I
may have missed it in the docs.
The policy is
https://fedoraproject.org/wiki/User:Adamwill/Draft_fedora_image_naming_policy . As currently written at least, it strictly reserves - as a field separator:
Fields may only contain ASCII alphanumeric characters and underscores.
Particularly of note, the character '-' is reserved for use as a field
separator. No field may itself contain that character.
so if it actually continues to be followed, this'd be safe. Although! It
did just occur to me to wonder what RHEL does...I have beta and RC1
images of RHEL 7 here and they both seem to use just '7.0' as the
Version in /.buildstamp , so we probably don't have to worry there, but
I don't know for sure.
> Unless they plan to do 21-1_Alpha_TC6
> or something like that, of course.
Who knows what the future may bring ;)
> Also, is it certain that they have not also changed the format in the
> treeinfo file? If they have, then version needs to be adjusted
> in the later block in the same method, as well. If not, probably that
> fact should go in the the comment.
Nice catch - I didn't spot that. In fact it is using _ , so I think it
does need fixing as well. See
I forgot to note that I believe this patch should be considered part of
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1134524 and hence
it's effectively a release blocker and can/should go to f21-branch.
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
More information about the anaconda-patches