[pykickstart][rhel7-branch/master][v3][PATCH 0/2] Validate network interface name when parsing the kickstart

Martin Kolman mkolman at redhat.com
Wed Sep 10 13:21:50 UTC 2014


On Wed, 2014-09-10 at 09:19 -0400, Anne Mulhern wrote:
> 
> 
> 
> ----- Original Message -----
> > From: "Martin Kolman" <mkolman at redhat.com>
> > To: anaconda-patches at lists.fedorahosted.org
> > Sent: Wednesday, September 10, 2014 7:03:47 AM
> > Subject: [pykickstart][rhel7-branch/master][v3][PATCH 0/2] Validate network	interface name when parsing the kickstart
> > 
> > Changes from v2:
> > * used partition() for parsing the name
> > * fixed the untranslatable error message
> > * added tests for incorrect usage of the 'vlan' prefix
> > * made the VLAN max/min module contants
> > * that _NoneType_ thing
> > 
> > Martin Kolman (2):
> >   Validate network interface name when parsing the kickstart (#1081982)
> >   Add tests for --interfacename validation
> > 
> >  pykickstart/commands/network.py | 57
> >  +++++++++++++++++++++++++++++++++++++++++
> >  tests/commands/network.py       | 32 +++++++++++++++++++++++
> >  2 files changed, 89 insertions(+)
> > 
> > --
> > 1.9.3
> > 
> > _______________________________________________
> > anaconda-patches mailing list
> > anaconda-patches at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > 
> 
> Looks good except that NoneType is just NoneType (no underscores).
Should have checked, fixing locally. :)
> 
> - mulhern
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list