[PATCH rhel7-branch] gui: add Refresh button to network storage UI (#1065716)

Chris Lumens clumens at redhat.com
Tue Sep 9 14:44:52 UTC 2014

> So ... the Refresh button.
> Should we add a tooltip?

I think the refresh label alone is probably good enough to explain what
the button is for.

> Should we make it less prominent?

I think the position's fine.  It's down with all the rest of the

> diff --git a/pyanaconda/ui/gui/spokes/filter.py b/pyanaconda/ui/gui/spokes/filter.py
> index 97b07ca..af2662c 100644
> --- a/pyanaconda/ui/gui/spokes/filter.py
> +++ b/pyanaconda/ui/gui/spokes/filter.py
> @@ -644,6 +644,10 @@ class FilterSpoke(NormalSpoke):
>          self._update_summary()
> +    def on_refresh_clicked(self, widget, *args):
> +        self.storage.devicetree.populate()
> +        self.refresh()
> +
>      def on_add_iscsi_clicked(self, widget, *args):
>          dialog = ISCSIDialog(self.data, self.storage)

Is devicetree.populate expected to take a significant amount of time?
If it can, we will need to add some more code here to make sure the
screen stays usable and the user knows what is going on.  This could
involve setting the spinning cursor or something else.

- Chris

More information about the anaconda-patches mailing list