[pykickstart][rhel7-branch/master][v2][PATCH 0/2] Validate network interface name when parsing the kickstart

Martin Kolman mkolman at redhat.com
Mon Sep 8 17:49:41 UTC 2014


Changes from v1:
* refactored the validation function out of the parse method
* the function returns an error message if it finds an invalid interface name,
  but None if it does not find an error
- like this there is just a single raise statement instead of 4
* error messages read as sentences
* hopefully more readable message for the invalid vlan.<vlan id> interface name
* out of range error message reports the valid range
* tests correctly inherit from F20 tests

Martin Kolman (2):
  Validate network interface name when parsing the kickstart (#1081982)
  Add tests for --interfacename validation

 pykickstart/commands/network.py | 55 +++++++++++++++++++++++++++++++++++++++++
 tests/commands/network.py       | 28 +++++++++++++++++++++
 2 files changed, 83 insertions(+)

-- 
1.9.3



More information about the anaconda-patches mailing list