[blivet:master/rhel7] Pylint inspired cleanup (#1070115)

David Shea dshea at redhat.com
Mon Sep 8 16:01:37 UTC 2014


On 09/08/2014 12:00 PM, mulhern wrote:
> Related: rhbz#1070115
>
> Should have gone in with commit 601010a242bf51d810600b3385d77a9399e40a30.
>
> Signed-off-by: mulhern <amulhern at redhat.com>
> ---
>   blivet/devicelibs/dasd.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/blivet/devicelibs/dasd.py b/blivet/devicelibs/dasd.py
> index 79530e9..b558fef 100644
> --- a/blivet/devicelibs/dasd.py
> +++ b/blivet/devicelibs/dasd.py
> @@ -136,7 +136,7 @@ def online_dasd(dev):
>       online = "/sys/bus/ccw/drivers/dasd-eckd/%s/online" % (dev)
>   
>       if not os.path.exists(online):
> -        log.info("Freeing DASD device %s" % dev)
> +        log.info("Freeing DASD device %s", dev)
>           util.run_program(["dasd_cio_free", "-d", dev])
>   
>       if not os.path.exists(online):
> @@ -150,7 +150,7 @@ def online_dasd(dev):
>               raise ValueError(_("Device %s is already online.") % dev)
>           else:
>               with open(online, "w") as f:
> -                log.debug("echo %s > %s" % ("1", online))
> +                log.debug("echo %s > %s", "1", online)
>                   f.write("%s\n" % ("1"))
>       except IOError as e:
>           raise ValueError(_("Could not set DASD device %(dev)s online (%(e)s).") \

Ack.


More information about the anaconda-patches mailing list