[pykickstart][rhel7-branch/master][PATCH 2/2] Add tests for --interfacename validation
Martin Kolman
mkolman at redhat.com
Mon Sep 8 15:14:13 UTC 2014
Related: rhbz#1081982
Signed-off-by: Martin Kolman <mkolman at redhat.com>
---
tests/commands/network.py | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/tests/commands/network.py b/tests/commands/network.py
index 9643c74..e421c0c 100644
--- a/tests/commands/network.py
+++ b/tests/commands/network.py
@@ -69,5 +69,34 @@ class F20_TestCase(CommandTest):
nd2 = self.assert_parse(s)
self.assertEquals(value, nd2.teamslaves)
+class RHEL7_TestCase(CommandTest):
+ command = "network"
+
+ def runTest(self):
+ # there needs to be a vlan id after a dot & only one dot is allowed
+ self.assert_parse_error("network --interfacename=abc.", KickstartValueError)
+ self.assert_parse_error("network --interfacename=abc.def", KickstartValueError)
+ self.assert_parse_error("network --interfacename=abc..", KickstartValueError)
+ self.assert_parse_error("network --interfacename=abc.123.456", KickstartValueError)
+ # 'vlan' can't be followed by a '.'
+ self.assert_parse_error("network --interfacename=vlan.123", KickstartValueError)
+ self.assert_parse_error("network --interfacename=vlan.", KickstartValueError)
+ self.assert_parse_error("network --interfacename=vlan..", KickstartValueError)
+ self.assert_parse_error("network --interfacename=vlan.abc", KickstartValueError)
+ self.assert_parse("network --interfacename=abc.123")
+
+ # if the device name begins with 'vlan', vlan id needs to follow
+ self.assert_parse_error("network --interfacename=vlan", KickstartValueError)
+ self.assert_parse_error("network --interfacename=vlanabcd", KickstartValueError)
+ self.assert_parse("network --interfacename=vlan123")
+
+ # vlan ids go from 0 to 4095
+ self.assert_parse("network --interfacename=vlan0")
+ self.assert_parse("network --interfacename=vlan4095")
+ self.assert_parse("network --interfacename=abc.0")
+ self.assert_parse("network --interfacename=abc.4095")
+ self.assert_parse_error("network --interfacename=vlan9001", KickstartValueError)
+ self.assert_parse_error("network --interfacename=abc.9001", KickstartValueError)
+
if __name__ == "__main__":
unittest.main()
--
1.9.3
More information about the anaconda-patches
mailing list