[blivet:master] Get rid of misleading comment (#1066721)
amulhern at redhat.com
Mon Sep 8 13:50:12 UTC 2014
----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Monday, September 8, 2014 8:27:21 AM
> Subject: Re: [blivet:master] Get rid of misleading comment (#1066721)
> On Mon, 2014-09-08 at 08:04 -0400, mulhern wrote:
> > Related: fed#1066721
> > Should have gone in with commit 1f8c93ecf1be236fd4ec2f00bf64fd2c69246761.
> ACK, just a question about english -- is there a mistake or does "go in
> with commit..." have some meaning uknown to me?
> Vratislav Podzimek
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
I think "should have been part of commit ..." would be more usual English.
The phrase probably arises because there's some cooking metaphor in the back
of my mind. In baking it would be quite common to say something like:
"Oh drat, the sugar should have gone in with the liquid ingredients."
I don't cook or bake actually, but I've observed other people make
that kind of mistake plenty of times.
More information about the anaconda-patches