[PATCH rhel7-branch] network: don't traceback on invalid team options (#1114282)

Vratislav Podzimek vpodzime at redhat.com
Fri Sep 5 07:48:40 UTC 2014


On Fri, 2014-09-05 at 09:46 +0200, Radek Vykydal wrote:
> On 09/02/2014 01:25 PM, Vratislav Podzimek wrote:
> > On Tue, 2014-09-02 at 09:08 +0200, Radek Vykydal wrote:
> >> Resolves: rhbz#1114282
> >>
> >> Log error message.
> >> In the case teamd dies and team device is not created so we
> >> are getting the UnknownDeviceError in nm.py.
> > I don't quite understand the relation between the commit message and
> > this description. Is the error because we got invalid team options or
> > because teamd died? Or is teamd dying a result of invalid options
> > passed?
> >
> 
> The latter is true. User creates team connection with invalid options
> in Connection Editor, NM activates the connection which activates
> teamd which dies, and the team device Anaconda is expecting
> to appear is not created so Anaconda tracebacks. The patch
> lets Anaconda survive with just logging error message.
> Quite a general message, but we are not able to tell more than
> that, for some reason, the team device was not created/found.
Makes sense, thanks for the additional explanation. Just please add the
note about the teamd dying and the reason for it to the commit
description.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list