[anaconda][master/rhel7-branch][PATCH 2/2] Add dialog box for adding DASDs. (#1070115)

Chris Lumens clumens at redhat.com
Tue Sep 2 20:34:33 UTC 2014


> diff --git a/pyanaconda/ui/gui/spokes/advstorage/dasd.glade b/pyanaconda/ui/gui/spokes/advstorage/dasd.glade
> new file mode 100644
> index 0000000..bd16e7f
> --- /dev/null
> +++ b/pyanaconda/ui/gui/spokes/advstorage/dasd.glade
> @@ -0,0 +1,362 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!-- Generated with glade 3.16.1 -->
> +<interface>
> +  <requires lib="gtk+" version="3.0"/>
> +  <object class="GtkDialog" id="dasdDialog">
> +    <property name="can_focus">False</property>
> +    <property name="border_width">5</property>

Border widths should be multiples of 6.  We do a much better job of this
on master than on rhel7-branch, but that's probably not critical enough
to go through and standardize.

> +            <child>
> +              <object class="GtkButton" id="cancelButton">
> +                <property name="label">gtk-cancel</property>

...

> +            <child>
> +              <object class="GtkButton" id="okButton">
> +                <property name="label">gtk-ok</property>

We're not supposed to use stock-id anymore.  See
983aff8b7cb8842f129e1760975c2133f487be4b.

- Chris


More information about the anaconda-patches mailing list